This repository was archived by the owner on Jan 8, 2020. It is now read-only.
Fix for #4727#4734
Closed
pauloelr wants to merge 7 commits into
Closed
Conversation
I always forget something about travis
Contributor
|
@pauloelr please add in unit tests that show the desired exception being raised. |
Contributor
|
Also you should replace "string" with "scalar" in: '%s expects parameter to be string, "%s" given', |
Found one more.
Check array in: Zend\Filter\BaseName Zend\Filter\Digits Zend\Filter\HtmlEntities Zend\Filter\RealPath
Contributor
|
@weierophinney since this technically could be a BC break should we target this at develop? More than likely it is not and just fixing a missing check for scalar values but figured I'd get your feedback :) |
weierophinney
added a commit
that referenced
this pull request
Jun 28, 2013
Member
|
@mwillbanks In each case, the filters were designed only to work with strings or integers/floats; these checks fix behavior issues when non-scalars. As such, I consider it a bugfix, and have merged. |
Closed
weierophinney
added a commit
to zendframework/zend-filter
that referenced
this pull request
May 15, 2015
…_filter_array_to_string Fix for zendframework/zendframework#4727
weierophinney
added a commit
to zendframework/zend-filter
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-filter
that referenced
this pull request
May 15, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check if parameter is scalar before cast to string
If not throw InvalidArgumentException
Fix for #4727