This repository was archived by the owner on Jan 8, 2020. It is now read-only.
Revise docblocks in Zend\Session\ContainerAbstractServiceFactory#4981
Closed
pwarnock wants to merge 1 commit into
Closed
Revise docblocks in Zend\Session\ContainerAbstractServiceFactory#4981pwarnock wants to merge 1 commit into
pwarnock wants to merge 1 commit into
Conversation
Member
|
Actually... docblocks are legacy in this case; that was the original intent, but during review of the code, we decided to drop the prefixing. So... I'll only accept this if you revert the code changes and instead remove the information in the docblocks. |
Contributor
Author
|
@weierophinney Thanks for the feedback. |
weierophinney
added a commit
that referenced
this pull request
Aug 21, 2013
…iner Revise docblocks in Zend\Session\ContainerAbstractServiceFactory
weierophinney
added a commit
to zendframework/zend-session
that referenced
this pull request
May 15, 2015
…fix/strip-off-session-container Revise docblocks in Zend\Session\ContainerAbstractServiceFactory
weierophinney
added a commit
to zendframework/zend-session
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-session
that referenced
this pull request
May 15, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docblocks indicate usage of SessionConainer\ prefix
and that normalizeContainerName strips off the prefix
Docblocks revised to show sample configuration without stripping prefix.