Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jan 8, 2020. It is now read-only.

Version update#2311

Merged
weierophinney merged 2 commits into
zendframework:masterfrom
BinaryKitten:VersionUpdate
Sep 13, 2012
Merged

Version update#2311
weierophinney merged 2 commits into
zendframework:masterfrom
BinaryKitten:VersionUpdate

Conversation

@BinaryKitten
Copy link
Copy Markdown
Contributor

Updates Zend\Version\Version to enable support for classic version retrieval from framework.zend.com

BinaryKitten and others added 2 commits September 7, 2012 11:30
added support for different version identifier locations
@b-durand
Copy link
Copy Markdown
Contributor

b-durand commented Sep 8, 2012

Good idea 👍

@coss
Copy link
Copy Markdown
Contributor

coss commented Sep 13, 2012

How about accepting as additional optional parameter, that excepts a Zend\Http\Client instance? That way, the developer could set the adapter which would make this method usable even if allow_url_fopen is set to off.

@weierophinney
Copy link
Copy Markdown
Member

@coss That's outside the scope of this PR; if you'd like to have that feature, please open a new request. :)

@weierophinney
Copy link
Copy Markdown
Member

Merged to release and master branches.

@weierophinney weierophinney merged commit 6f41798 into zendframework:master Sep 13, 2012
@ghost ghost assigned weierophinney Sep 13, 2012
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zend Service Identifier?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this has already been merged and done, I've created #2404

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants