This repository was archived by the owner on Jan 8, 2020. It is now read-only.
Bug in Zend\ModuleManager\Listener\LocatorRegistrationListener#2350
Closed
bedeabza wants to merge 4 commits into
Closed
Bug in Zend\ModuleManager\Listener\LocatorRegistrationListener#2350bedeabza wants to merge 4 commits into
bedeabza wants to merge 4 commits into
Conversation
… shared event manager can be false
… shared event manager can be false
…za/zf2 into bug-locator-registration-listener
Member
There was a problem hiding this comment.
This can be simply:
if ($events) {
getSharedManager() can return either null, false, or a SharedEventManagerInterface instance.
Member
There was a problem hiding this comment.
And, actually, I'd change this entirely to:
if (!$events) {
return;
}
and then continue on with the event registration. Nothing else in this method is necessary if we don't have the shared event manager instance.
weierophinney
pushed a commit
that referenced
this pull request
Sep 14, 2012
weierophinney
added a commit
that referenced
this pull request
Sep 14, 2012
- Use MvcEvent::EVENT_BOOTSTRAP instead of 'bootstrap' - Whitespace around conditional statements
Member
|
There was something wrong with the commit history due to the presence of a merge in the branch, and I ended up cherry-picking the commit. Merged to master and release branches. |
Contributor
Author
|
Sorry about that, I had already pushed the changes when I realized there was something wrong and merged back the origin. |
weierophinney
pushed a commit
to zendframework/zend-modulemanager
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-modulemanager
that referenced
this pull request
May 15, 2015
- Use MvcEvent::EVENT_BOOTSTRAP instead of 'bootstrap' - Whitespace around conditional statements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared event manager can be false sometimes and at lines 70 and 85 this wasn't checked so I caught some errors while running tests for a new module.
I'm not even sure if this is due to errors in my configuration, but considering that the shared event manager is not always returned we should check for it.