!IE support for conditional comments powered viewhelper#4679
Conversation
|
Tests are missing, I guess. |
|
i guess there is no need for additional tests^^ |
|
@redaxmedia actually there is a need for additional tests to ensure the behavior that you had added actually works. The behavior was not there before and in the event it would be removed in the future no tests would break so it would seem like all is OK with the world. |
If this was understood as a generalization, wouldn't that mean that no tests are required ever? |
|
Unit tests added, they are working well under zf1 I could not test it under zf2, because my VM Image does not have latest PHPUnit and I could not get it to update because of limited permission. Sorry for that. |
!IE support for conditional comments powered viewhelper
|
Fixed CS issues and merged to develop for release with 2.3.0. |
…aster !IE support for conditional comments powered viewhelper
- trailing whitespace
Support for conditional comments with !IE by adding the inner wrap with comment end and start.
<!--[if IE 6]>
<p>You are using Internet Explorer 6.</p>
<![endif]-->
<!--[if !IE]><!-->
<p>You are not using Internet Explorer.</p>
<!--<![endif]-->