This repository was archived by the owner on Jan 8, 2020. It is now read-only.
Fix spelling of "marshall"#4912
Merged
Merged
Conversation
"Marshall" is a proper noun. The verb you were going for is "marshal" (one "L").
Author
|
Opps, this should be against master, not develop. |
Member
|
You're correct. However, changing the method name is a BC break. I'll merge, but I'm going to do the following:
That way, if anybody was extending the class previously, their code will continue to work. I'll have it raise an E_USER_DEPRECATED warning, however. As such, I'll also target this for 2.3.0, and merge only to the develop branch for now. |
weierophinney
added a commit
that referenced
this pull request
Aug 19, 2013
Fix spelling of "marshall"
weierophinney
added a commit
that referenced
this pull request
Aug 19, 2013
- and have it proxy to the renamed version, while raising an E_USER_DEPRECATED error.
weierophinney
added a commit
that referenced
this pull request
Aug 19, 2013
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Marshall" is a proper noun. The verb you were going for is "marshal" (one "L").