This repository was archived by the owner on Jan 8, 2020. It is now read-only.
[SessionManagerFactory] Configuration of validators in SessionManagerFactory#4995
Closed
Blinden wants to merge 2 commits into
Closed
[SessionManagerFactory] Configuration of validators in SessionManagerFactory#4995Blinden wants to merge 2 commits into
Blinden wants to merge 2 commits into
Conversation
Member
|
Please add a unit test for this functionality. |
Contributor
|
Failures in the build are not due to this change. Looking more into the change. |
Contributor
|
We may want to create this as a separate service; such that it would be a SessionValidatorService which could take an array of options that could provide the validators and attach. That would be the only area that this might need to scale out for. |
Member
|
@mwillbanks Considering this is a composed object in the SessionManager, I think having it in the same factory is fine. Merging for 2.3.0. |
weierophinney
added a commit
that referenced
this pull request
Oct 22, 2013
[SessionManagerFactory] Configuration of validators in SessionManagerFactory
weierophinney
added a commit
that referenced
this pull request
Oct 22, 2013
Member
|
Merged to develop for release with 2.3.0. |
weierophinney
added a commit
to zendframework/zend-session
that referenced
this pull request
May 15, 2015
…ion-manager-factory-validators [SessionManagerFactory] Configuration of validators in SessionManagerFactory
weierophinney
added a commit
to zendframework/zend-session
that referenced
this pull request
May 15, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is merely a cut and past from http://framework.zend.com/manual/2.2/en/modules/zend.session.manager.html to add handling of validators in the SessionManagerFactory
If this is a good addition I will write the tests