This repository was archived by the owner on Jan 8, 2020. It is now read-only.
Added optional charset to pdo dsn#5064
Closed
stefankleff wants to merge 2 commits into
Closed
Conversation
Member
|
The correct place to add a test for this would be ./tests/ZendTest/Db/Adapter/Driver/Pdo/ConnectionTest.php. Unfortunately, it looks like there's not really any existing tests for this class for you to reference. Also, the way the |
Author
|
That's why I've asked :) Unfortunately I don't have the time to refactor the class (and add test for that too). |
Member
|
I believe this was addressed with #4973 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was not possible to set the charset of the connection, now it can be passed as configuration parameter.
If somebody could give me a hint how - I'll also write a test :)