This repository was archived by the owner on Jan 8, 2020. It is now read-only.
hotfix/4508 and make Zend\Http\Header\SetCookie RFC conform#5078
Closed
ClemensSahs wants to merge 9 commits into
Closed
hotfix/4508 and make Zend\Http\Header\SetCookie RFC conform#5078ClemensSahs wants to merge 9 commits into
ClemensSahs wants to merge 9 commits into
Conversation
Contributor
Author
|
last thing to do is fix the bug in fromString. |
Member
|
@ClemensSahs Please see https://travis-ci.org/ClemensSahs/zf2/jobs/10994478#L475 - looks like either the test expectation is incorrect, or the urlencoding has gone awry. |
Contributor
Author
|
@weierophinney the reason behind this error:
I think this is near this line perhaps we muss refactor the logic. Currently i have no finial solution. |
support qouted value without urldecode bug
Contributor
Author
|
so I'm ready with this PR but I found that // current implementation
Set-Cookie: SID=31d4d96e407aad42; Path=/; Secure; HttpOnly, lang=en-US; Path=/; Domain=example.com
// standart conform
Set-Cookie: SID=31d4d96e407aad42; Path=/; Secure; HttpOnly
Set-Cookie: lang=en-US; Path=/; Domain=example.com |
Contributor
Author
|
ok I'm fine here, any annotations? |
weierophinney
added a commit
that referenced
this pull request
Sep 6, 2013
hotfix/4508 and make Zend\Http\Header\SetCookie RFC conform
weierophinney
added a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
…hotfix/4508 hotfix/4508 and make Zend\Http\Header\SetCookie RFC conform
weierophinney
added a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hotfix for the issues #4508