This repository was archived by the owner on Jan 8, 2020. It is now read-only.
Update label view helper to have html escape by default#5101
Merged
weierophinney merged 2 commits intoOct 22, 2013
Merged
Conversation
stefanotorresi
pushed a commit
to stefanotorresi/zf2-documentation
that referenced
this pull request
Sep 11, 2013
* Add FormRow docs * Some corrections here and there * Add docs for zendframework/zendframework#4677 and zendframework/zendframework#5101
added 2 commits
October 18, 2013 16:46
weierophinney
added a commit
that referenced
this pull request
Oct 22, 2013
Update label view helper to have html escape by default
weierophinney
added a commit
that referenced
this pull request
Oct 22, 2013
- Since this is technically a BC break, we need to call it out in the release notes.
weierophinney
added a commit
that referenced
this pull request
Oct 22, 2013
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replicates the
FormRowview helper logic, which escapes theElementlabelproperty by default and takes advantage of the newdisable_html_escapelabelOptionsproperty added in #4677 to toggle the escape off when needed.This may look like a minor BC break, because anyone who used
FormLabelhelper rather thanFormRowwill now have unexpected escaping, but since the overall policy of ZF2 is 'secure by default' I would rather consider this a minor security fix.