This repository was archived by the owner on Jan 8, 2020. It is now read-only.
Create Callback adapter for Zend\Paginator#5272
Closed
henriquemoody wants to merge 1 commit into
Closed
Conversation
Contributor
|
👍 |
Contributor
|
@henriquemoody please add docblock statements on all the methods |
Author
|
@macnibblet, I really think this is unnecessary, but I amended the commit for it. |
Contributor
|
@henriquemoody Coding standards.... :) |
Author
|
@macnibblet, I thought Zend Framework was PSR compliance and there is no requirement of documentation blocks on PSR's. |
Contributor
|
@henriquemoody PSR is just a standard that ZF2 own standard happens to follow. Check out this ;) http://framework.zend.com/wiki/display/ZFDEV2/Coding+Standards#CodingStandards-Functions that wiki itself is no more mantained, but i think most of that page currently applies. |
Author
|
Thanks for this link, @stefanotorresi. :) |
weierophinney
added a commit
that referenced
this pull request
Oct 23, 2013
Create Callback adapter for Zend\Paginator
weierophinney
added a commit
that referenced
this pull request
Oct 23, 2013
- Updated docblocks to use better grammatical phrasing.
weierophinney
added a commit
that referenced
this pull request
Oct 23, 2013
Member
|
Merged to develop for release with 2.3.0. |
weierophinney
added a commit
to zendframework/zend-paginator
that referenced
this pull request
May 15, 2015
…y/paginator_adapter_callback Create Callback adapter for Zend\Paginator
weierophinney
added a commit
to zendframework/zend-paginator
that referenced
this pull request
May 15, 2015
- Updated docblocks to use better grammatical phrasing.
weierophinney
added a commit
to zendframework/zend-paginator
that referenced
this pull request
May 15, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.