This repository was archived by the owner on Jan 8, 2020. It is now read-only.
Zend Db: Multiple nested selects - Zend Paginator with nested select bind parameters error#5392
Closed
ralphschindler wants to merge 1 commit into
Closed
Zend Db: Multiple nested selects - Zend Paginator with nested select bind parameters error#5392ralphschindler wants to merge 1 commit into
ralphschindler wants to merge 1 commit into
Conversation
* Select Joins should share state when processing subselect * Decorators should be propagated down into subselects
Member
|
Can you try the attached PR for me? |
Author
|
I've tested your PR, everything is now working. Thanks! |
weierophinney
added a commit
that referenced
this pull request
Apr 11, 2014
…joins-sharing-process-state Zend Db: Multiple nested selects - Zend Paginator with nested select bind parameters error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using 2.2.4 with mysqli.
Zend\Db\Sql\AbstractSql->processSubSelect
This method keeps track of the number of subselects and so parameter keys do not get overwritten. However when using the Zend Paginator you get a:
Warning: mysqli_stmt::bind_param(): Number of variables doesn't match number of parameters in prepared statement
The code to replicate this is at https://gist.github.com/nicklevett/7253154.
This what is produced by Zend\Db\Adapter\ParameterContainer->merge:
But should be:
The subselect is not incremented so subselect1where1 gets overwritten