Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jan 8, 2020. It is now read-only.

Set custom class name for active li element#5650

Closed
k8ns wants to merge 8 commits into
zendframework:masterfrom
k8ns:patch-1
Closed

Set custom class name for active li element#5650
k8ns wants to merge 8 commits into
zendframework:masterfrom
k8ns:patch-1

Conversation

@k8ns
Copy link
Copy Markdown
Contributor

@k8ns k8ns commented Dec 30, 2013

Add ability to set custom class name for active "li" element in menu.
Example:
echo $this->navigation('navigation')->menu()
->setUlClass('uk-navbar-nav uk-hidden-small')
->setLiActiveClass('uk-active')
->setMaxDepth(0)
->setRenderInvisible(false);

k8ns added 3 commits December 30, 2013 04:00
@k8ns
Set custom class name for active li element
dd9e18b 
Add ability to set custom class name for active "li" element in menu.
Example:
echo $this->navigation('navigation')->menu()
     ->setUlClass('uk-navbar-nav uk-hidden-small')
     ->setLiActiveClass('uk-active')
     ->setMaxDepth(0)
     ->setRenderInvisible(false);
@k8ns
Create css2.html for test LiActiveClass method
a091a41
@k8ns
Add test for munu liActiveClass method
575fc60
@froschdesign
Copy link
Copy Markdown
Member

froschdesign commented Dec 30, 2013

There are some problems:

Please look at ZF1 for a complete implementation:

I think we should grab the implementation from version 1.

samsonasik
samsonasik reviewed Dec 30, 2013
View reviewed changes
Comment thread library/Zend/View/Helper/Navigation/Menu.php
Copy link
Copy Markdown
Contributor

@samsonasik samsonasik Dec 30, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@return self

Copy link
Copy Markdown
Member

@froschdesign froschdesign Dec 30, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samsonasik
At this point the "CS police" is not needed! Because the entire implementation from sopinorg is bad.

@k8ns
Copy link
Copy Markdown
Contributor Author

k8ns commented Dec 31, 2013

@froschdesign @samsonasik thanks for advice! I have added fixes to Menu.php.

@weierophinney weierophinney added this to the 2.3.0 milestone Mar 3, 2014
@weierophinney weierophinney self-assigned this Mar 4, 2014
weierophinney added a commit that referenced this pull request Mar 4, 2014
@weierophinney
Merge pull request #5650 from sopinorg/patch-1
8bd15b6 
Set custom class name for active li element
weierophinney added a commit that referenced this pull request Mar 4, 2014
@weierophinney
[#5650] CS fixes
cafd7ec 
- trailing whitespace
- s/@return Menu/@return self/ throughout
weierophinney added a commit that referenced this pull request Mar 4, 2014
@weierophinney
[#5650] Test fix
93ae4e1 
- including test asset files often results in additional whitespace at
  end of string; updated assertion to trim() first.
weierophinney added a commit that referenced this pull request Mar 4, 2014
@weierophinney
Merge branch 'feature/5650' into develop
372638d 
Close #5650
@weierophinney
Copy link
Copy Markdown
Member

weierophinney commented Mar 4, 2014

Merged to develop for release with 2.3.0.

@froschdesign
Copy link
Copy Markdown
Member

froschdesign commented Mar 6, 2014

@stefanotorresi
?

@stefanotorresi
Copy link
Copy Markdown
Contributor

stefanotorresi commented Mar 6, 2014

$liActiveClass parameter in renderNormalMenu() and renderDeepestMenu() not being optional causes a strict error for any Menu subclass. there are plenty of modules that extends it for custom menu rendering.

working on a fix with tests...

@froschdesign
Copy link
Copy Markdown
Member

froschdesign commented Mar 6, 2014

renderNormalMenu and renderDeepestMenu are protected methods – is this a BC break? (in the past, it was not)

stefanotorresi pushed a commit to stefanotorresi/zf2 that referenced this pull request Mar 6, 2014
fix menu helper bc break introduced by zendframework#5650
b931996
@stefanotorresi
Copy link
Copy Markdown
Contributor

stefanotorresi commented Mar 6, 2014

Well it is debatable for sure, but after all it's protected, not private.
Extended Menu helpers, which are quite common, are now triggering strict standards errors with this patch, and this is a fact. :p

I'll try and work on a fix anyway.

@stefanotorresi stefanotorresi mentioned this pull request Mar 6, 2014
Closed
stefanotorresi pushed a commit to stefanotorresi/ZfcTwitterBootstrap that referenced this pull request Mar 10, 2014
fix compatibility with zendframework/zendframework#5650
d37cc3d
mwillbanks pushed a commit to mwillbanks/ZfcTwitterBootstrap that referenced this pull request Nov 23, 2014
Merge pull request #48 from stefanotorresi/fix/zf2.3-compatibility
9121558 
fix compatibility with zendframework/zendframework#5650
weierophinney added a commit to zendframework/zend-view that referenced this pull request May 15, 2015
@weierophinney
Merge pull request zendframework/zendframework#5650 from sopinorg/pat…
24db2d7 
…ch-1

Set custom class name for active li element
weierophinney added a commit to zendframework/zend-view that referenced this pull request May 15, 2015
@weierophinney
[zendframework/zendframework#5650] CS fixes
5769771 
- trailing whitespace
- s/@return Menu/@return self/ throughout
weierophinney added a commit to zendframework/zend-view that referenced this pull request May 15, 2015
@weierophinney
[zendframework/zendframework#5650] Test fix
0b1d1ce 
- including test asset files often results in additional whitespace at
  end of string; updated assertion to trim() first.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@weierophinney weierophinney

Labels

None yet

Projects

None yet

Milestone

2.3.0

Development

Successfully merging this pull request may close these issues.

5 participants

@k8ns @froschdesign @weierophinney @stefanotorresi @samsonasik