This repository was archived by the owner on Jan 8, 2020. It is now read-only.
Fixed the classmap autoloader to work under Windows in Phar files.#5813
Closed
slaff wants to merge 1 commit into
Closed
Fixed the classmap autoloader to work under Windows in Phar files.#5813slaff wants to merge 1 commit into
slaff wants to merge 1 commit into
Conversation
(Example path: 'phar://D:/GDrive/zs-client.phar/module/Client/autoload_classmap.php')
Contributor
|
@slaff can you provide a unit test to cover this use case? Thanks. |
Author
|
@ezimuel There is already test case for this that before this patch was failing under Windows. The name of the test is testCanLoadClassMapFromPhar and is here: https://github.com/zendframework/zf2/blob/master/tests/ZendTest/Loader/ClassMapAutoloaderTest.php#L168 |
Contributor
|
Merged with commit @6f2d37956f |
weierophinney
added a commit
that referenced
this pull request
Feb 11, 2014
Fixed the classmap autoloader to work under Windows in Phar files.
weierophinney
added a commit
that referenced
this pull request
Feb 11, 2014
Forward port #5813 Conflicts: library/Zend/Code/Reflection/FunctionReflection.php library/Zend/Code/Reflection/MethodReflection.php tests/ZendTest/Code/Reflection/FunctionReflectionTest.php
Member
|
Merged to develop as well with 4d8a7eb |
weierophinney
added a commit
to zendframework/zend-loader
that referenced
this pull request
May 15, 2015
Forward port zendframework/zendframework#5813 Conflicts: library/Zend/Code/Reflection/FunctionReflection.php library/Zend/Code/Reflection/MethodReflection.php tests/ZendTest/Code/Reflection/FunctionReflectionTest.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following change makes it possible to use the classmap autoloader also under Windows in phar context.
(Example path: 'phar://D:/GDrive/zs-client.phar/module/Client/autoload_classmap.php')