Zend\Cache\Storage\Adapter\Memcache#5829
Conversation
|
Thanks for the review, @samsonasik. I think I've gotten everything buttoned up now. Let me know if I've missed anything. |
|
👍 |
There was a problem hiding this comment.
This method could be dropped as the memcache extension doesn't support setting items as bulk and setting it as a loop should be done already by the abstract adapter.
There was a problem hiding this comment.
Thanks. I think I was going cross-eyed from comparing the Memcache/Memcached documentation and was looking at the wrong setMulti page at the time. Will fix.
|
Only the above comments found. |
…et multiple value internal method
|
Thanks @marc-mabe for the review. I think I've got all of your comments addressed, except for the one about booleans that I've replied to. Let me know if there's anything else I've missed. Thanks again. |
|
Finished testing differences between ext/memcache 3.x beta and 2.x stable versions, which affects the adapter capabilities: https://github.com/cgmartin/zf2/blob/2c1649e9ca8b7683cd10ad0e65e178a60af49cf5/library/Zend/Cache/Storage/Adapter/Memcache.php#L481-517 |
|
I had commented on the method |
There was a problem hiding this comment.
The lib_options was in the memcached adapter to proxy to Memcached::setOption which changes from version to version. In my opinion it isn't needed for ext/memcache and it would be better to make it a normal getter/setter [get|set]AutoCompressThreshold and [get|set]AutoCompressMinSaving
There was a problem hiding this comment.
Yeah, I can empathize with that. My original thought was to try make it similar to the Memcached adapter config, but at second glance it just seems awkward here. Will do.
|
@marc-mabe regarding the
|
Zend\Cache\Storage\Adapter\Memcache
New cache storage adapter for ext/memcache (not to be confused with existing ext/memcached adapter).
Implements feature request: #4481
An example configuration for
Zend\Cache\StorageFactorywould be: