This repository was archived by the owner on Jan 8, 2020. It is now read-only.
[Zend\Filter\Compress] added PHP 5.4 support for strings in Bz2 and Gz decompress#5839
Merged
Conversation
added 2 commits
February 11, 2014 15:13
Maks3w
added a commit
that referenced
this pull request
Feb 18, 2014
Maks3w
added a commit
that referenced
this pull request
Feb 18, 2014
Maks3w
added a commit
that referenced
this pull request
Feb 18, 2014
gianarb
pushed a commit
to zendframework/zend-filter
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-filter
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-filter
that referenced
this pull request
May 15, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR Zend\Filter\Compress\Bz2 and Zend\Filter\Compress\Gz are capable of decompressing Strings in PHP 5.4 without throwing a Warning like stated in #5788
In my research I found out, that the only problem are null byte characters, so we go for a check if there is a null byte char in the given content.
The skipped tests are working now in PHP >= 5.4