This repository was archived by the owner on Jan 8, 2020. It is now read-only.
Fixes #4943#5853
Closed
samsonasik wants to merge 3 commits into
Closed
Conversation
Member
|
Is this ready or a WIP? |
Contributor
Author
|
I'm done. but let me know if any suggestion / revision ;). Thanks. |
Member
|
I ask b/c there are a couple of new skipped tests. |
Contributor
Author
|
As I said at #4943 , I'm stuck on mocking test, if any suggestion to make it work without skipped test, let me know ;) |
ralphschindler
pushed a commit
that referenced
this pull request
Mar 7, 2014
Merge branch 'fix/db_rowcounter' of git://github.com/samsonasik/zf2 into feature/5853-adapter-row-counter-partial-fix * 'fix/db_rowcounter' of git://github.com/samsonasik/zf2: added tests for getCountForStatement, getCountForSql, getRowCountClosure fix namespace and add test for getCountForStatement Fixes #4943
ralphschindler
pushed a commit
that referenced
this pull request
Mar 7, 2014
Merge branch 'feature/5853-adapter-row-counter-partial-fix' into develop * feature/5853-adapter-row-counter-partial-fix: Zend\Db\Adapter\Pdo added unit tests to row counter fix added tests for getCountForStatement, getCountForSql, getRowCountClosure fix namespace and add test for getCountForStatement Fixes #4943
Member
|
Merged to develop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4943