This repository was archived by the owner on Jan 8, 2020. It is now read-only.
Fix for #5894 - .il Domain checking#5900
Closed
moderndeveloperllc wants to merge 2 commits into
Closed
Conversation
…s; update validTLDs from IANA website; Add a few more Cyrillic IDN checking strings from IANA website; Use UTF8 string wrapper for strlen calls; Clean up TLD checking (if we are using getTldCheck() == true we don't need any further checking of the TLD validity); Add new tests for some of the new UTF-8 TLDs
Contributor
Author
|
Not sure why Travis failed. The unit tests I updated passed and there were no formatting issues. |
Member
|
@moderndeveloperllc the failure is not related with your issue |
weierophinney
added a commit
that referenced
this pull request
Mar 5, 2014
Fix for #5894 - .il Domain checking
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
…perllc/feature/5894 Fix for zendframework/zendframework#5894 - .il Domain checking
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for Issue #5894
There is more cleaning up to do in this class: