This repository was archived by the owner on Jan 8, 2020. It is now read-only.
FormRow generetes invalid HTML for MonthSelect#5920
Closed
grizzm0 wants to merge 1 commit into
Closed
Conversation
weierophinney
added a commit
that referenced
this pull request
Mar 7, 2014
…elect FormRow generetes invalid HTML for MonthSelect
weierophinney
added a commit
that referenced
this pull request
Mar 7, 2014
weierophinney
added a commit
that referenced
this pull request
Mar 7, 2014
Member
|
Merged to develop for release with 2.3.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FormRow renders invalid HTML for MonthSelect, DateSelect and DateTimeSelect. A label can only be assigned to a single input while the mentioned classes generates a group of inputs.
DateSelect and DateTimeSelect both extends MonthSelect. Hence only checking MonthSelect.
Would I need any tests for this? Should I test the output of FormRow? If so, then I'd also have to check for ext/intl in the test.