This repository was archived by the owner on Jan 8, 2020. It is now read-only.
Fix for missing required option for CollectionInputFilter#5926
Closed
fabiocarneiro wants to merge 2 commits into
Closed
Fix for missing required option for CollectionInputFilter#5926fabiocarneiro wants to merge 2 commits into
fabiocarneiro wants to merge 2 commits into
Conversation
Contributor
|
👍 |
weierophinney
added a commit
that referenced
this pull request
Mar 7, 2014
…-input-filter-required Fix for missing required option for CollectionInputFilter
weierophinney
added a commit
that referenced
this pull request
Mar 7, 2014
- Align operators - Comma after last array element
weierophinney
added a commit
that referenced
this pull request
Mar 7, 2014
Member
|
Merged to develop for release with 2.3.0. |
weierophinney
added a commit
to zendframework/zend-inputfilter
that referenced
this pull request
May 15, 2015
…o/hotfix-factory-collection-input-filter-required Fix for missing required option for CollectionInputFilter
weierophinney
added a commit
to zendframework/zend-inputfilter
that referenced
this pull request
May 15, 2015
- Align operators - Comma after last array element
weierophinney
added a commit
to zendframework/zend-inputfilter
that referenced
this pull request
May 15, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the CollectionInputFilter class has a $isRequired option defaulted to false, we need to have a required index in the factory array, so we can force validation on that element. Otherwise, it will always ignore the collection and return valid.