This repository was archived by the owner on Jan 8, 2020. It is now read-only.
code-to-explain-code test in MultiCheckboxTest to check multi selected #6070
Closed
Victory wants to merge 1 commit into
Closed
code-to-explain-code test in MultiCheckboxTest to check multi selected #6070Victory wants to merge 1 commit into
Victory wants to merge 1 commit into
Conversation
Contributor
Author
|
I am not sure how to restart travis-ci for this example. The build broke because of |
Contributor
|
maybe you can rebase against master and do git push --force |
Contributor
Author
|
Thank you @samsonasik, right now github seems to be having network errors, once that is fixed i will try the rebase/force. On my own travis-ci test i can manually request a rebuild is that not an option here? |
Contributor
|
I think travis is ok now, the failed build is not related with your PR ;) |
Contributor
Author
|
Yeah it seems to keep failing on other things but my PR seemed fine, will this PR even be considered until i can get the green mark from travis? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it may be a bit confusing on how an
$optionValueand$selectedOptionswork together withZend\Form\Element\MultiCheckboxfor those who are not usingZend\Form\View\Helper\FormMultiCheckboxI hope this test will explain this issue in code and that people will feel more comfortable creating their own view helpers in the future.Thank you for you consideration!