Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jan 8, 2020. It is now read-only.

Validator\Ip should not allow newlines in any case.#6104

Merged
weierophinney merged 1 commit into
zendframework:masterfrom
sasezaki:validator_newslines_regex
Apr 14, 2014
Merged

Validator\Ip should not allow newlines in any case.#6104
weierophinney merged 1 commit into
zendframework:masterfrom
sasezaki:validator_newslines_regex

Conversation

@sasezaki
Copy link
Copy Markdown
Contributor

@sasezaki sasezaki commented Apr 8, 2014 

<?php
use Zend\Validator\Ip;

var_dump((new Ip)->isValid("127.000.000.001"));  // true (expected)
var_dump((new Ip)->isValid("127.000.000.001\n")); // true (Unexpected)
var_dump((new Ip)->isValid("127.0.0.1\n")); //false (expected)

This issue was caused by ZF-10621
29516d4#diff-1f6ffee384d80d41af718d92b4b7ea76R144

related fix http://framework.zend.com/issues/browse/ZF-8640

@sasezaki
Validator\Ip should not allow newlines in any case.
6d4c84d 
This issue was caused by ZF-10621
@Ocramius Ocramius added this to the 2.3.1 milestone Apr 8, 2014
weierophinney added a commit that referenced this pull request Apr 14, 2014
@weierophinney
Merge pull request #6104 from sasezaki/validator_newslines_regex
950936a 
Validator\Ip should not allow newlines in any case.
weierophinney added a commit that referenced this pull request Apr 14, 2014
@weierophinney
Merge branch 'hotfix/6104' into develop
1f5b1c9 
Forward port #6104
@weierophinney weierophinney merged commit 6d4c84d into zendframework:master Apr 14, 2014
@weierophinney weierophinney self-assigned this Apr 14, 2014
weierophinney added a commit that referenced this pull request Apr 14, 2014
@weierophinney
Merge branch 'hotfix/6104'
f4552c5 
Close #6104
@sasezaki sasezaki deleted the validator_newslines_regex branch April 17, 2014 13:42
weierophinney added a commit to zendframework/zend-validator that referenced this pull request May 15, 2015
@weierophinney
Merge pull request zendframework/zendframework#6104 from sasezaki/val…
ec3566b 
…idator_newslines_regex

Validator\Ip should not allow newlines in any case.
weierophinney added a commit to zendframework/zend-validator that referenced this pull request May 15, 2015
@weierophinney
Merge branch 'hotfix/6104'
1e149f3 
Close zendframework/zendframework#6104
weierophinney added a commit to zendframework/zend-validator that referenced this pull request May 15, 2015
@weierophinney
Merge branch 'hotfix/6104' into develop
8936878 
Forward port zendframework/zendframework#6104
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@weierophinney weierophinney

Labels

bug Validator

Projects

None yet

Milestone

2.3.1

Development

Successfully merging this pull request may close these issues.

3 participants

@sasezaki @weierophinney @Ocramius