Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jan 8, 2020. It is now read-only.

Fix invalid step error caused by DST#6245

Merged
Ocramius merged 3 commits into
zendframework:masterfrom
davidwindell:hotfix-dst-dates
May 10, 2014
Merged

Fix invalid step error caused by DST#6245
Ocramius merged 3 commits into
zendframework:masterfrom
davidwindell:hotfix-dst-dates

Conversation

@davidwindell
Copy link
Copy Markdown
Contributor

We need to force UTC on the DateStepValidator, otherwise, changes in DST causes it to fail due to the base date being an hour out.

Comment thread library/Zend/Form/Element/DateTime.php Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unused use.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't prefix non-public members with _

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, that will teach me for copying from other tests classes!

@Ocramius Ocramius self-assigned this May 9, 2014
@Ocramius Ocramius added this to the 2.3.2 milestone May 9, 2014
@Ocramius
Copy link
Copy Markdown
Member

Ocramius commented May 9, 2014

Except for CS, this is mergeable

@Ocramius Ocramius merged commit ccfa646 into zendframework:master May 10, 2014
Ocramius added a commit that referenced this pull request May 10, 2014
Ocramius added a commit that referenced this pull request May 10, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants