This repository was archived by the owner on Jan 8, 2020. It is now read-only.
Handle regular form elements as target elements of Zend\Form\Element\Collection.#6298
Closed
erispre wants to merge 3 commits into
Closed
Handle regular form elements as target elements of Zend\Form\Element\Collection.#6298erispre wants to merge 3 commits into
Zend\Form\Element\Collection.#6298erispre wants to merge 3 commits into
Conversation
Fielset, then add a CollectionInput instead of a regular input filter, respecting the target's input specification. Added Zend\InputFilter\CollectionInput and associated test case. Added tests to ZendTest/Form/Element/CollectionTest
|
I don't think you need to create a new class Have a look at #6497 and #6498 for a way of instantiating a CollectionInputFilter automatically when a collection is encountered. |
Member
|
@erispre Does the suggestion by @SteveTalbot address the use case you have? If so, we should close this. If not, can you explain how the use cases differ, so we can message when to use which type? |
Contributor
|
@erispre #6880 should fix this issue, could you pull it down and try it out? (https://github.com/adamlundrigan/zf2/tree/zf6518) |
Member
|
#6880 was merged, so this just needs to be verified. |
Member
|
I'll just merge the tests from this patch. |
Ocramius
added a commit
that referenced
this pull request
Dec 28, 2014
Note that attribution will be given only as a comment to the commit, since rebasing/squashing the commits to avoid changes to unaffected code-paths is problematic. If this doesn't match expectations, then please ask for a revert and send the test code in a separate pull request.
Ocramius
added a commit
that referenced
this pull request
Dec 28, 2014
…-collection-element' into develop Close #6298
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes below allow for setting regular form elements (i.e. not a
Zend\Form\Fieldset) as the target element of a form collection. Before this patch, this would create problems when binding a domain model. Now, a new input (Zend\InputFilter\CollectionInput-- basically aArrayInputwith some minor changes to message handling) is set for the collection when no input filter configuration is provided. This input will take the validators and filters of the target element and loop over an array of values. This way, domain models can be hydrated from form data. (Before this, there would be no inputs nor input filters attached to theCollection's default input filter, so all values would be lost afterForm::isValid()was called).This pull request addresses issue #6263.