This repository was archived by the owner on Jan 8, 2020. It is now read-only.
unused parameters $sm for plugins factory#6393
Closed
jmleroux wants to merge 3 commits into
Closed
Conversation
Member
|
Just for the record: The failing test on PHP 5.6 is not due to this PR. |
Contributor
Author
A problem with fractionnal DateTime in PHP 5.6 |
Member
|
We shouldn't allow failures in 5.6. Please revert the change on |
Contributor
Author
⏪ done |
Ocramius
added a commit
that referenced
this pull request
Aug 6, 2014
…nager-factory' into develop Forward port #6393
Member
|
@jmleroux I removed the commits related to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.