Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jan 8, 2020. It is now read-only.

6649#6655

Closed
monkeyphp wants to merge 4 commits into
zendframework:masterfrom
monkeyphp:6649
Closed

6649#6655
monkeyphp wants to merge 4 commits into
zendframework:masterfrom
monkeyphp:6649

Conversation

@monkeyphp
Copy link
Copy Markdown
Contributor

I've removed the exception being throw when the valueOptions array is empty. I feel that there is a valid use case for the array to be empty - for example, in database backed forms.

@Martin-P
Copy link
Copy Markdown
Contributor

What does happen when no value_options are provided? I think that needs a test case.

@Ocramius Ocramius added this to the 2.3.4 milestone Dec 24, 2014
@Ocramius Ocramius self-assigned this Dec 24, 2014
Ocramius added a commit that referenced this pull request Dec 30, 2014
Ocramius added a commit that referenced this pull request Dec 30, 2014
…ns-in-form-element-renderer' into develop

Close #6655
Close #6649
Forward port #6655
Forward port #6649
@Ocramius Ocramius closed this in 30394c8 Dec 30, 2014
@Ocramius
Copy link
Copy Markdown
Member

Merged and added tests, thanks @monkeyphp and @Martin-P!

master: 30394c8
develop: 5bbb449

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants