Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jan 8, 2020. It is now read-only.

Fix for BC break #6645 where isValid() sets up old values#6711

Closed
Martin-P wants to merge 2 commits into
zendframework:masterfrom
Martin-P:issue-6645
Closed

Fix for BC break #6645 where isValid() sets up old values#6711
Martin-P wants to merge 2 commits into
zendframework:masterfrom
Martin-P:issue-6645

Conversation

@Martin-P
Copy link
Copy Markdown
Contributor

PR #6295 (Fieldset ignore disabled elements) introduced a BC break: #6645 (isValid sets up old values?).

This PR fixes #6645 and as a result leads to less code for ignoring disabled elements.

@Martin-P
Copy link
Copy Markdown
Contributor Author

Martin-P commented Dec 2, 2014

There were no failing test cases, because there was no test for the issue. PR #6614 has those tests and should be used instead of this PR. The test from this PR is added in #6614.

I will leave this open until #6614 is merged.

@Ocramius
Copy link
Copy Markdown
Member

Ocramius commented Dec 5, 2014

Handled in #6614

@Ocramius Ocramius closed this Dec 5, 2014
@Ocramius Ocramius added this to the 2.3.4 milestone Dec 5, 2014
@Martin-P Martin-P deleted the issue-6645 branch January 3, 2015 23:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

isValid sets up old values?

2 participants