This repository was archived by the owner on Jan 8, 2020. It is now read-only.
Removed hard coded dependency to Zend\Mvc from Zend\ModuleManager#7060
Closed
RalfEggert wants to merge 2 commits into
Closed
Removed hard coded dependency to Zend\Mvc from Zend\ModuleManager#7060RalfEggert wants to merge 2 commits into
RalfEggert wants to merge 2 commits into
Conversation
Member
|
This can gladly land in 2.3.4 as well |
Contributor
Author
|
Sounds great. I just wonder if the https://github.com/zendframework/zf2/blob/master/library/Zend/ModuleManager/composer.json shouldn't be amended as well? |
Member
|
@RalfEggert yes please :-) |
Contributor
Author
|
I'll do it tonight. |
Contributor
Author
|
I only deleted the |
Member
|
@RalfEggert should probably still be in |
Contributor
Author
|
Hmm. But it wasn't in the |
Member
|
Nope, the hard dep should go away, but the tests may still rely on the Mvc component (has to be checked, eventually) |
Member
|
Merged after cherry-picking onto a new branch from |
gianarb
pushed a commit
to zendframework/zend-modulemanager
that referenced
this pull request
May 15, 2015
…nager-mvc-dependency' Close zendframework/zendframework#7060
gianarb
pushed a commit
to zendframework/zend-modulemanager
that referenced
this pull request
May 15, 2015
…nager-mvc-dependency' into develop Close zendframework/zendframework#7060 Forward port zendframework/zendframework#7060
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the hard coded dependency to the
Zend\Mvc\MvcEvent::EVENT_BOOTSTRAPconstant fromZend\ModuleManagercomponent by adding a new constant toZend\ModuleManager\ModuleManager.Look at #6933