bot: fix cs [skip ci]

nikophil · nikophil · commit 792077af48ff · 2026-02-02T18:57:01.000+01:00
diff --git a/src/PHPUnit/KernelTestCaseHelper.php b/src/PHPUnit/KernelTestCaseHelper.php
@@ -30,7 +30,7 @@ public static function getContainer(string $class): Container
         }
 
         return (\Closure::bind(
-            fn() => $class::getContainer(),
+            static fn() => $class::getContainer(),
             newThis: null,
             newScope: $class,
         ))();
@@ -67,7 +67,7 @@ public static function bootKernel(string $class): KernelInterface
         }
 
         return (\Closure::bind(
-            fn() => $class::bootKernel(),
+            static fn() => $class::bootKernel(),
             newThis: null,
             newScope: $class,
         ))();
diff --git a/src/PHPUnit/ResetDatabase/ResetDatabaseOnPreparationStarted.php b/src/PHPUnit/ResetDatabase/ResetDatabaseOnPreparationStarted.php
@@ -53,7 +53,7 @@ private function shouldReset(Event\Code\TestMethod $test): bool
     {
         $hasResetDatabaseAttribute = AttributeReader::classOrParentsHasAttribute($test->className(), ResetDatabase::class);
 
-        if (!is_subclass_of($test->className(), KernelTestCase::class)) {
+        if (!\is_subclass_of($test->className(), KernelTestCase::class)) {
             if ($hasResetDatabaseAttribute) {
                 throw new \LogicException(\sprintf('Class "%s" cannot use attribute #[ResetDatabase] if it does not extend "%s".', $test->className(), KernelTestCase::class));
             }
diff --git a/src/PHPUnit/ResetDatabase/ResetDatabaseOnTestSuiteStarted.php b/src/PHPUnit/ResetDatabase/ResetDatabaseOnTestSuiteStarted.php
@@ -62,7 +62,7 @@ public function notify(Event\TestSuite\Started $event): void
      */
     private function shouldReset(string $testClassName): bool
     {
-        if (!is_subclass_of($testClassName, KernelTestCase::class)) {
+        if (!\is_subclass_of($testClassName, KernelTestCase::class)) {
             return false;
         }
 
diff --git a/src/Persistence/ResetDatabase/ResetDatabaseManager.php b/src/Persistence/ResetDatabase/ResetDatabaseManager.php
@@ -18,7 +18,6 @@
 use Zenstruck\Foundry\Configuration;
 use Zenstruck\Foundry\Exception\PersistenceNotAvailable;
 use Zenstruck\Foundry\Persistence\PersistenceManager;
-use Zenstruck\Foundry\PHPUnit\ResetDatabase\ResetDatabaseOnTestSuiteStarted;
 use Zenstruck\Foundry\Tests\Fixture\TestKernel;
 
 /**
@@ -76,7 +75,6 @@ public static function resetBeforeEachTest(KernelInterface $kernel): void
                 throw $e;
             }
 
-
             // allow this to fail if running foundry test suite
             return;
         }
diff --git a/src/Test/ResetDatabase.php b/src/Test/ResetDatabase.php
@@ -18,7 +18,6 @@
 use Zenstruck\Foundry\Attribute\ResetDatabase as ResetDatabaseAttribute;
 use Zenstruck\Foundry\Configuration;
 use Zenstruck\Foundry\Persistence\ResetDatabase\ResetDatabaseManager;
-use Zenstruck\Foundry\PHPUnit\AttributeReader;
 use Zenstruck\Foundry\PHPUnit\FoundryExtension;
 
 /**
diff --git a/tests/Integration/DataProvider/DataProviderWithPersistentFactoryTestCase.php b/tests/Integration/DataProvider/DataProviderWithPersistentFactoryTestCase.php
@@ -225,7 +225,7 @@ public static function createOneObjectInDataProviderWithAfterPersistCallback():
     {
         yield [
             static::factory()
-                ->afterPersist(fn(GenericModel $object) => $object->setProp1('after persist callback'))
+                ->afterPersist(static fn(GenericModel $object) => $object->setProp1('after persist callback'))
                 ->create(),
         ];
     }
diff --git a/tests/Integration/InMemory/InMemoryAttributeOnMethodTest.php b/tests/Integration/InMemory/InMemoryAttributeOnMethodTest.php
@@ -24,6 +24,7 @@
 use Zenstruck\Foundry\Tests\Fixture\Entity\Address;
 use Zenstruck\Foundry\Tests\Fixture\Factories\Entity\Address\AddressFactory;
 use Zenstruck\Foundry\Tests\Integration\RequiresORM;
+
 use function Zenstruck\Foundry\Persistence\delete;
 
 /**
diff --git a/tests/Integration/Persistence/GenericFactoryUsingBeforeHooksTestCase.php b/tests/Integration/Persistence/GenericFactoryUsingBeforeHooksTestCase.php
@@ -11,20 +11,20 @@
 
 namespace Zenstruck\Foundry\Tests\Integration\Persistence;
 
-use Zenstruck\Foundry\Tests\Fixture\Factories\Entity\GenericEntityFactory;
 use PHPUnit\Framework\Attributes\Before;
 use PHPUnit\Framework\Attributes\Test;
 use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
 use Zenstruck\Foundry\Test\Factories;
 use Zenstruck\Foundry\Test\ResetDatabase;
+use Zenstruck\Foundry\Tests\Fixture\Factories\Entity\GenericEntityFactory;
 use Zenstruck\Foundry\Tests\Integration\RequiresORM;
 
 /**
  * @author Nicolas PHILIPPE <nikophil@gmail.com>
  */
 abstract class GenericFactoryUsingBeforeHooksTestCase extends KernelTestCase
 {
-    use Factories, ResetDatabase, RequiresORM;
+    use Factories, RequiresORM, ResetDatabase;
 
     protected function setUp(): void
     {
diff --git a/tests/Integration/ResetDatabase/OrmEdgeCaseTestCase.php b/tests/Integration/ResetDatabase/OrmEdgeCaseTestCase.php
@@ -43,7 +43,7 @@ public function it_can_use_flush_after_and_entity_from_global_state(): void
         $relationshipWithGlobalEntityFactory = persistent_factory(RelationshipWithGlobalEntity\RelationshipWithGlobalEntity::class);
         $globalEntitiesCount = persistent_factory(GlobalEntity::class)::repository()->count();
 
-        flush_after(function() use ($relationshipWithGlobalEntityFactory) {
+        flush_after(static function() use ($relationshipWithGlobalEntityFactory) {
             $relationshipWithGlobalEntityFactory->create(['globalEntity' => GlobalStory::globalEntity()]);
         });
 
diff --git a/utils/rector/src/ResetDatabaseAttributeRector.php b/utils/rector/src/ResetDatabaseAttributeRector.php
@@ -49,7 +49,7 @@ public function refactor(Node $node): ?Node
         );
 
         if ([] === $traitUseWithResetDatabase->traits) {
-            $node->stmts = \array_filter($node->stmts, fn(Node\Stmt $stmt) => $stmt !== $traitUseWithResetDatabase);
+            $node->stmts = \array_filter($node->stmts, static fn(Node\Stmt $stmt) => $stmt !== $traitUseWithResetDatabase);
         }
 
         $hasResetDatabaseTrait = (bool) $this->nodeFinder->findFirst($node->attrGroups, function(Node $node): bool {

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ private function shouldReset(Event\Code\TestMethod $test): bool`
`53`	`53`	`{`
`54`	`54`	`$hasResetDatabaseAttribute = AttributeReader::classOrParentsHasAttribute($test->className(), ResetDatabase::class);`
`55`	`55`
`56`		`- if (!is_subclass_of($test->className(), KernelTestCase::class)) {`
	`56`	`+ if (!\is_subclass_of($test->className(), KernelTestCase::class)) {`
`57`	`57`	`if ($hasResetDatabaseAttribute) {`
`58`	`58`	`throw new \LogicException(\sprintf('Class "%s" cannot use attribute #[ResetDatabase] if it does not extend "%s".', $test->className(), KernelTestCase::class));`
`59`	`59`	`}`
Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ public function notify(Event\TestSuite\Started $event): void`
`62`	`62`	`*/`
`63`	`63`	`private function shouldReset(string $testClassName): bool`
`64`	`64`	`{`
`65`		`- if (!is_subclass_of($testClassName, KernelTestCase::class)) {`
	`65`	`+ if (!\is_subclass_of($testClassName, KernelTestCase::class)) {`
`66`	`66`	`return false;`
`67`	`67`	`}`
`68`	`68`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,6 @@`
`18`	`18`	`use Zenstruck\Foundry\Configuration;`
`19`	`19`	`use Zenstruck\Foundry\Exception\PersistenceNotAvailable;`
`20`	`20`	`use Zenstruck\Foundry\Persistence\PersistenceManager;`
`21`		`-use Zenstruck\Foundry\PHPUnit\ResetDatabase\ResetDatabaseOnTestSuiteStarted;`
`22`	`21`	`use Zenstruck\Foundry\Tests\Fixture\TestKernel;`
`23`	`22`
`24`	`23`	`/**`
`@@ -76,7 +75,6 @@ public static function resetBeforeEachTest(KernelInterface $kernel): void`
`76`	`75`	`throw $e;`
`77`	`76`	`}`
`78`	`77`
`79`		`-`
`80`	`78`	`// allow this to fail if running foundry test suite`
`81`	`79`	`return;`
`82`	`80`	`}`
Original file line number	Diff line number	Diff line change
`@@ -225,7 +225,7 @@ public static function createOneObjectInDataProviderWithAfterPersistCallback():`
`225`	`225`	`{`
`226`	`226`	`yield [`
`227`	`227`	`static::factory()`
`228`		`- ->afterPersist(fn(GenericModel $object) => $object->setProp1('after persist callback'))`
	`228`	`+ ->afterPersist(static fn(GenericModel $object) => $object->setProp1('after persist callback'))`
`229`	`229`	`->create(),`
`230`	`230`	`];`
`231`	`231`	`}`
Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ public function refactor(Node $node): ?Node`
`49`	`49`	`);`
`50`	`50`
`51`	`51`	`if ([] === $traitUseWithResetDatabase->traits) {`
`52`		`- $node->stmts = \array_filter($node->stmts, fn(Node\Stmt $stmt) => $stmt !== $traitUseWithResetDatabase);`
	`52`	`+ $node->stmts = \array_filter($node->stmts, static fn(Node\Stmt $stmt) => $stmt !== $traitUseWithResetDatabase);`
`53`	`53`	`}`
`54`	`54`
`55`	`55`	`$hasResetDatabaseTrait = (bool) $this->nodeFinder->findFirst($node->attrGroups, function(Node $node): bool {`