fix: remove unreachable modified detection in MerkleDAG.compare() (#294)

Poojan-patel · web-flow · commit c0cc3cce4c2b · 2026-04-22T12:17:08.000+08:00
Remove unreachable modified detection in MerkleDAG.compare() — node IDs are SHA-256 of data, so same ID guarantees same data. Simplify return type to { added, removed }.
diff --git a/packages/core/src/sync/merkle.ts b/packages/core/src/sync/merkle.ts
@@ -78,22 +78,13 @@ export class MerkleDAG {
         return dag;
     }
 
-    public static compare(dag1: MerkleDAG, dag2: MerkleDAG): { added: string[], removed: string[], modified: string[] } {
-        const nodes1 = new Map(Array.from(dag1.getAllNodes()).map(n => [n.id, n]));
-        const nodes2 = new Map(Array.from(dag2.getAllNodes()).map(n => [n.id, n]));
-
-        const added = Array.from(nodes2.keys()).filter(k => !nodes1.has(k));
-        const removed = Array.from(nodes1.keys()).filter(k => !nodes2.has(k));
-        
-        // For modified, we'll check if the data has changed for nodes that exist in both
-        const modified: string[] = [];
-        for (const [id, node1] of Array.from(nodes1.entries())) {
-            const node2 = nodes2.get(id);
-            if (node2 && node1.data !== node2.data) {
-                modified.push(id);
-            }
-        }
+    public static compare(dag1: MerkleDAG, dag2: MerkleDAG): { added: string[], removed: string[] } {
+        const nodes1 = new Set(Array.from(dag1.getAllNodes()).map(n => n.id));
+        const nodes2 = new Set(Array.from(dag2.getAllNodes()).map(n => n.id));
+
+        const added = Array.from(nodes2).filter(k => !nodes1.has(k));
+        const removed = Array.from(nodes1).filter(k => !nodes2.has(k));
 
-        return { added, removed, modified };
+        return { added, removed };
     }
 } 
diff --git a/packages/core/src/sync/synchronizer.ts b/packages/core/src/sync/synchronizer.ts
@@ -236,8 +236,8 @@ export class FileSynchronizer {
         // Compare the DAGs
         const changes = MerkleDAG.compare(this.merkleDAG, newMerkleDAG);
 
-        // If there are any changes in the DAG, we should also do a file-level comparison
-        if (changes.added.length > 0 || changes.removed.length > 0 || changes.modified.length > 0) {
+        // If there are any changes in the DAG, do a file-level comparison
+        if (changes.added.length > 0 || changes.removed.length > 0) {
             console.log('[Synchronizer] Merkle DAG has changed. Comparing file states...');
             const fileChanges = this.compareStates(this.fileHashes, newFileHashes);
 
