Clarify goals of unpinned-tools
#2027
Replies: 1 comment
-
|
Hi @vetleledaal, thanks for opening an issue. Yeah, I think this would be a good fit for a discussion: at the moment the primary goal of In general, I'd like to see this audit be generalized to cover those kinds of cases, and getting user/community feedback on what they'd fine useful on that topic (in terms of value/minimizing alert fatigue) would be very valuable. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Pre-submission checks
What's the problem this feature will solve?
unpinned-toolsmixes different threat models, which was briefly discussed in #1775 (comment).If I had to categorize the threat models into different tiers:
8daa57c044...v1.2.3v1latest,mainCurrently
unpinned-toolsonly protect against accidental breaking changes. Outside of that, you have different degrees of remedies available. Which varies widely. I have collected some below.Internally checked with checksum (T1)
astral-sh/setup-uvsecurego/gosec(not configurable)zizmorcore/zizmor-actionHardcoded to mutable reference (T3)
super-linter/super-linterHardcoded to mutable reference (T4)
mikefarah/yqHardcoded to latest (T5)
pre-commit/actionwith.versiondefaults tolatest(T5), accepts mutable reference (T3)appleboy/ssh-actionoven-sh/setup-bun(validates checksum, but tags are not locked)trufflesecurity/trufflehogenv.WRANGLER_VERSIONdefaults to4(T4), accepts mutable reference (T3)cloudflare/wrangler-actionwith.override_versiondefaults to""(T5), accepts hash (T1)ansible/ansible-lintDescribe the solution you'd like
The goals of the
unpinned-toolsaudit should be clearly defined.latestfine (i.e. T1-T4)?apt?pipx,npx, ...)?Additional context
Practically I would say it should alert only if its on latest (implicit / explicit) and the user can do something about it. There's a slight mismatch with the security model in
unpinned-toolsandunpinned-uses, but there's not much you can do about it if you want to use most workflows / avoid alert fatigue.I have not taken other audit rules into account.
Unsure if this fits better as an issue or discussion. Please move as appropriate.
Beta Was this translation helpful? Give feedback.
All reactions