Details
- Reviewers
dshin - Commits
- rMOZILLACENTRAL3f95b778f233: Bug 1888098 - optimize nth-of dependency tracking for custom state r=dshin
- Bugzilla Bug ID
- 1888098
Diff Detail
- Repository
- rMOZILLACENTRAL mozilla-central
- Build Status
Buildable 643907 Build 742617: arc lint + arc unit
Event Timeline
@dshin this is a follow on from your comment here: https://phabricator.services.mozilla.com/D202460#inline-1136717.
This adds customstate tracking in CascadeData. I'm not sure how to write a test to verify this is doing the thing I hope it is, but it compiles and passers the existing customstatetests.
If you could point me in the right direction on where to write a test to confirm that'd be great.
Minor nitpicks, looks good otherwise. Thanks!
As for testing, yes it should be good as long as state-css-selector-nth-of.html holds.
| servo/components/style/stylist.rs | ||
|---|---|---|
| 2029 | Shouldn't it be AtomIdent? It is the same thing for Gecko but it'd be nicer for Servo to backport. | |
| 2153 | Probably a good idea to add a comment why custom state special cases - i.e. It's invalid to consider :state() in a vacuum without considering what it's referring to (I don't think I worded it quite right, though...). | |
This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!