Thanks to visit codestin.com
Credit goes to phabricator.services.mozilla.com

Page MenuHomePhabricator
Differential D72603

Bug 1599415 trigger `focus` when details summary element is clicked r?TYLin
ClosedPublic
Actions

Authored by keithamus on Apr 27 2020, 9:08 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Feb 5, 9:50 PM
Unknown Object (File)
Jan 26 2026, 12:13 PM
Unknown Object (File)
Jan 26 2026, 12:34 AM
Unknown Object (File)
Dec 12 2025, 12:31 AM
Unknown Object (File)
Dec 11 2025, 11:38 PM
Unknown Object (File)
Dec 11 2025, 9:50 PM
Unknown Object (File)
Dec 11 2025, 9:49 PM
Unknown Object (File)
Dec 11 2025, 9:33 PM
View All 83 Files
Subscribers
emilio
lobot
muan

Details

Reviewers
TYLin
smaug
Commits
rMOZILLACENTRAL1ea874b6ead8: Bug 1599415 trigger `focus` when details summary element is clicked r=TYLin…
Bugzilla Bug ID
1599415

Diff Detail

Event Timeline

keithamus created this revision.Apr 27 2020, 9:08 AM
Herald added a project: secure-revision. · View Herald TranscriptApr 27 2020, 9:08 AM
Harbormaster completed remote builds in B188701: Diff 267450.Apr 27 2020, 9:08 AM
phab-bot requested review of this revision.Apr 27 2020, 9:08 AM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
keithamus updated this revision to Diff 267452.Apr 27 2020, 9:12 AM
keithamus retitled this revision from Bug 1599415 trigger `focus` when details summary element is clicked to Bug 1599415 trigger `focus` when details summary element is clicked r?TYLin.
keithamus edited the summary of this revision. (Show Details)
keithamus added a reviewer: TYLin.
Harbormaster completed remote builds in B188703: Diff 267452.Apr 27 2020, 9:12 AM
keithamus added a subscriber: muan.Apr 27 2020, 9:14 AM

/cc @muan for co-authoring this with me!

emilio added a subscriber: emilio.Apr 27 2020, 10:13 AM

Thanks for the patch! Does Safari pass this test? The mouse-focuses-form-control behavior is trying to match Mac platform behavior.

emilio added a comment.Apr 27 2020, 10:33 AM
In D72603#2207974, @emilio wrote:

Thanks for the patch! Does Safari pass this test? The mouse-focuses-form-control behavior is trying to match Mac platform behavior.

Ah, from the bug it seems Safari does trigger focus for click on summary. So this looks fine to me though I'll let @TYLin confirm.

Thanks again!

TYLin accepted this revision.Apr 27 2020, 9:22 PM
TYLin added a reviewer: smaug.

I tested clicking <summary> on Safari 13.0.5 and Chrome 81 on macOS, both are focusable. So I'm OK to align <summary>'s focus behavior with other browsers on macOS.

Although I'm the original author of the modified code, but I'm not an expert in event handling. I'll defer the final judgment to one of the peer in the module, in case I missed something.

dom/html/HTMLSummaryElement.cpp
109

Please remove "on other platforms" since the main summary element is now focusable across all the platforms.

testing/web-platform/tests/html/semantics/interactive-elements/the-summary-element/click-behavior-optional.html
22–24 ↗(On Diff #267452)

Since Firefox's behavior is going to match other browsers in this patch, I would suggest changing the sentence after "but" to something like "but setting focus on a clicked summary tag is the current behavior on Windows and macOS for Chrome, Safari, and Firefox".

smaug accepted this revision.Apr 28 2020, 4:21 PM
This revision is now accepted and ready to land.Apr 28 2020, 4:21 PM
smaug added inline comments.Apr 28 2020, 4:23 PM
testing/web-platform/tests/html/semantics/interactive-elements/the-summary-element/click-behavior-optional.html
1 ↗(On Diff #267452)

The name of the file should probably contain tentative in it, to hint the spec might not be super clear on this.

keithamus updated this revision to Diff 270354.Apr 30 2020, 3:41 PM
Harbormaster completed remote builds in B190822: Diff 270354.Apr 30 2020, 3:41 PM
keithamus marked 3 inline comments as done.Apr 30 2020, 3:42 PM
keithamus updated this revision to Diff 270360.Apr 30 2020, 3:45 PM
Harbormaster completed remote builds in B190828: Diff 270360.Apr 30 2020, 3:45 PM
TYLin added a comment.May 1 2020, 5:26 PM

Hi keithamus,

If this patch is ready, you can use "Add Action" -> "Change Project Tag" to add "Check-in Needed" to let sheriff team to land this patch for you.

keithamus added a project: Check-in Needed.May 3 2020, 6:55 PM

Thanks for the assistance @TYLin! Very new to this workflow 😛

lobot removed a project: Check-in Needed.May 3 2020, 7:44 PM
lobot added a subscriber: lobot.

Check-in Needed handled, landing queued.

TYLin removed a parent revision: D72602: Backed out changeset 779722364805 (Bug 1628583) per request a=backout.May 5 2020, 9:09 PM
TYLin added a comment.May 5 2020, 9:13 PM

I removed the parent revision D72602, which doesn't seem to be relevant to this patch.

Closed by commit rMOZILLACENTRAL1ea874b6ead8: Bug 1599415 trigger `focus` when details summary element is clicked r=TYLin… (authored by keithamus). · Explain WhyMay 5 2020, 9:13 PM
This revision was automatically updated to reflect the committed changes.
keithamus added a commit: rMOZILLACENTRAL1ea874b6ead8: Bug 1599415 trigger `focus` when details summary element is clicked r=TYLin….

Revision Contents
Changeset List

PathSize
dom/
html/
9 lines
testing/
web-platform/
tests/
html/
semantics/
interactive-elements/
the-summary-element/
39 lines

Diff 273028

View Options

dom/html/HTMLSummaryElement.cpp

Loading...
View Options

testing/web-platform/tests/html/semantics/interactive-elements/the-summary-element/click-behavior-optional.tentative.html

Loading...
Privacy · Cookies · Legal