Thanks to visit codestin.com
Credit goes to postgrespro.com

Request a Demo
Home   >   mailing lists

pgsql: Fix a gradual memory leak in ExecReScanAgg(). - Mailing list pgsql-committers

From [email protected] (Neil Conway)
Subject pgsql: Fix a gradual memory leak in ExecReScanAgg().
Date
Msg-id [email protected]
Whole thread Raw
List pgsql-committers
Tree view 
Log Message:
-----------
Fix a gradual memory leak in ExecReScanAgg(). Because the aggregation
hash table is allocated in a child context of the agg node's memory
context, MemoryContextReset() will reset but *not* delete the child
context. Since ExecReScanAgg() proceeds to build a new hash table
from scratch (in a new sub-context), this results in leaking the
header for the previous memory context. Therefore, use
MemoryContextResetAndDeleteChildren() instead.

Credit: My colleague Sailesh Krishnamurthy at Truviso for isolating
the cause of the leak.

Tags:
----
REL7_4_STABLE

Modified Files:
--------------
    pgsql/src/backend/executor:
        nodeAgg.c (r1.116.2.3 -> r1.116.2.4)

(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/nodeAgg.c.diff?r1=1.116.2.3&r2=1.116.2.4)

pgsql-committers by date:

Previous
From: [email protected] (Neil Conway)
Date:
Subject: pgsql: Fix a gradual memory leak in ExecReScanAgg().
Next
From: [email protected] (Tom Lane)
Date:
Subject: pgsql: Revise postmaster startup/shutdown logic to eliminate the problem