Thanks to visit codestin.com
Credit goes to postgrespro.com

Re: Perl coding error in msvc build system? - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Perl coding error in msvc build system?
Date
Msg-id [email protected]
Whole thread Raw
In response to Re: Perl coding error in msvc build system?  (Robert Haas <[email protected]>)
Responses Re: Perl coding error in msvc build system?
List pgsql-hackers
> This patch been reviewed by 4 people, resulting in 2 minor suggestions
> for changes (adding an m modifier, and removing a bogus last).
>
> It has 2 clear upvotes and 0 downvotes.
>
> I think it should be revised along the lines suggested and committed
> without further ado.

My patch actually only covered the first of the two faulty locations I
pointed out.  Attached is a patch that also fixes the second one.  I
noticed that DetermineVisualStudioVersion() is never called with an
argument, so I removed that branch altogether.


Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Expanding the use of FLEXIBLE_ARRAY_MEMBER for declarations like foo[1]
Next
From: Jim Nasby
Date:
Subject: Re: Allow "snapshot too old" error, to prevent bloat