Add a new experimental flag DD_TRACE_EXPERIMENTAL_RUNTIME_ID_ENABLED flag #4473
Conversation
|
👋 Hey @DataDog/ruby-guild, please fill "Change log entry" section in the pull request description. If changes need to be present in CHANGELOG.md you can state it this way **Change log entry**
Yes. A brief summary to be placed into the CHANGELOG.md(possible answers Yes/Yep/Yeah) Or you can opt out like that **Change log entry**
None.(possible answers No/Nope/None) Visited at: 2025-03-19 00:57:45 UTC |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4473 +/- ##
==========================================
- Coverage 97.76% 97.76% -0.01%
==========================================
Files 1390 1390
Lines 84748 84773 +25
Branches 4281 4282 +1
==========================================
+ Hits 82856 82875 +19
- Misses 1892 1898 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Datadog ReportBranch report: ✅ 0 Failed, 20808 Passed, 1373 Skipped, 3m 17.33s Total Time |
BenchmarksBenchmark execution time: 2025-03-21 19:36:52 Comparing candidate commit 1ba663c in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics. |
ee171e0 to
0485243
Compare
…to enable runtime ID collection for runtime metrics. This flag is disabled by default.
… to the GettingStarted
1ba663c to
96f1c3c
Compare
What does this PR do?
Adds a new flag
DD_TRACE_EXPERIMENTAL_RUNTIME_ID_ENABLEDto enable runtime ID collection for runtime metrics. This flag is disabled by default.Motivation:
We ultimately want to collect the
runtime-idtag by default, so this will allow us to collect these tags on an opt-in basis and give us better data to evaluate its impact on metrics collection.Change log entry
Since this adds a feature flag,
Additional Notes:
This avoids adding the name
DD_TRACE_EXPERIMENTAL_RUNTIME_ID_ENABLEDto a const because this flag may not be necessary if we determine we can enable this by default. If that's an issue, I can change that.APMAPI-1225
How to test the change?
This PR contains unit tests to assert that the
runtime-idtag is included in the set of default tags from theDatadog::Core::Runtime::Metricsinstance. Since I'm new to the dd-trace-rb repo, I'm not sure what other tests you'd like to see. Feedback is welcome!