Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@universalmind303
Copy link
Member

Changes Made

adds

  • dt.millisecond
  • dt.microsecond
  • dt.nanosecond

Related Issues

partially implements #4094

Checklist

  • Documented in API Docs (if applicable)
  • [n/a] Documented in User Guide (if applicable)

@codecov
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

Attention: Patch coverage is 74.82517% with 36 lines in your changes missing coverage. Please review.

Project coverage is 76.14%. Comparing base (8fe5a2b) to head (aa2efbb).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-core/src/series/ops/time.rs 53.33% 21 Missing ⚠️
src/daft-core/src/python/series.rs 0.00% 9 Missing ⚠️
daft/series.py 50.00% 3 Missing ⚠️
src/daft-core/src/array/ops/time.rs 95.45% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4128      +/-   ##
==========================================
- Coverage   78.42%   76.14%   -2.28%     
==========================================
  Files         787      787              
  Lines      100864   105113    +4249     
==========================================
+ Hits        79105    80043     +938     
- Misses      21759    25070    +3311     
Files with missing lines Coverage Δ
daft/expressions/expressions.py 93.90% <100.00%> (+0.04%) ⬆️
src/daft-functions/src/python/mod.rs 100.00% <100.00%> (ø)
src/daft-functions/src/python/temporal.rs 100.00% <ø> (ø)
src/daft-functions/src/temporal/mod.rs 67.36% <100.00%> (+0.70%) ⬆️
src/daft-sql/src/modules/temporal.rs 90.00% <100.00%> (+0.81%) ⬆️
src/daft-sql/src/planner.rs 82.49% <100.00%> (+0.03%) ⬆️
daft/series.py 89.45% <50.00%> (-0.34%) ⬇️
src/daft-core/src/array/ops/time.rs 87.08% <95.45%> (+1.44%) ⬆️
src/daft-core/src/python/series.rs 93.49% <0.00%> (-1.21%) ⬇️
src/daft-core/src/series/ops/time.rs 65.93% <53.33%> (-4.14%) ⬇️

... and 21 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@universalmind303 universalmind303 merged commit 720b87e into main Apr 2, 2025
48 of 50 checks passed
@universalmind303 universalmind303 deleted the universalmind303/dt.millisecond branch April 2, 2025 00:16
universalmind303 added a commit that referenced this pull request Apr 2, 2025
## Changes Made

adds `day_of_year` to get the ordinal day 

## Note for Reviewers

the OP requested this to be called `ordinal_day`, but many engines call
this `dayofyear`, which I feel fits better with our current naming (e.g.
`day_of_week`). They both do the same thing though. (The day 1-366
(january 1st - dec 31st with optional leap day))






## Related Issues

depends on #4128

## Checklist

- [x] Documented in API Docs (if applicable)
- [n/a] Documented in User Guide (if applicable)
- [n/a] If adding a new documentation page, doc is added to
`docs/mkdocs.yml` navigation
- [n/a] Documentation builds and is formatted properly (tag @/ccmao1130
for docs review)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants