chore(keyring-controller): fix new lint errors #7334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7273f0b to
66b6c1d
Compare
ccharly
commented
Dec 8, 2025
| wallet = wallet ?? (await Wallet.fromV3(input, password, true)); | ||
| } | ||
| privateKey = bytesToHex(wallet.getPrivateKey()); | ||
| privateKey = bytesToHex(new Uint8Array(wallet.getPrivateKey())); |
Contributor
Author
There was a problem hiding this comment.
Looks like Buffer is not compatible with Uint8Array here for some reason?
| let privateKey; | ||
| switch (strategy) { | ||
| case AccountImportStrategy.privateKey: | ||
| case AccountImportStrategy.privateKey: { |
Contributor
Author
There was a problem hiding this comment.
Declare a block-scope now, since we're doing some local vars declarations, and that's not allowed without block-scopes!
| const candidates = await Promise.all( | ||
| this.#keyrings.map(async ({ keyring }) => { | ||
| return Promise.all([keyring, keyring.getAccounts()]); | ||
| return [keyring, await keyring.getAccounts()] as const; |
Contributor
Author
There was a problem hiding this comment.
Not sure why Promise.all was used here, but we effectively just need to await keyring.getAccounts() here.
I've also added the as const to properly type [..., ...] as a tuple.
Comment on lines
+494
to
+496
| /** | ||
| * Keyring selector used for `withKeyring`. | ||
| */ |
Contributor
Author
There was a problem hiding this comment.
Added for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Fix existing lint errors (since the introduction of the new linting configuration).
Those are the bare minimum required to avoid having a failing CI for any new change to this controller.
References
N/A
Checklist
Note
Fixes lint/type issues across
KeyringController(explicit return types, nullish coalescing, tuple typing, safer conversions) and adds/exportKeyringBuildertype; updates changelog and ESLint suppressions.packages/keyring-controller/src/KeyringController.ts):createNewVaultAndKeychain,verifyPassword,signPersonalMessage, private helpers); use??instead of||; refine error variable names; ensureawaitordering and tuple typing (as const); adjust indices with?? 0.Keyringand add/export newKeyringBuildertype; updatekeyringBuilderFactoryto returnKeyringBuilderand typed builder function.bytesToHex(new Uint8Array(wallet.getPrivateKey())); minor logic cleanups in account import and keyring selection.KeyringBuildertype inpackages/keyring-controller/CHANGELOG.md.packages/keyring-controller/src/KeyringController.tsreflecting resolved lint errors.Written by Cursor Bugbot for commit 66b6c1d. This will update automatically on new commits. Configure here.