Add a way to choose between class or package instantiation mode for JaxbContext#2005
Merged
velo merged 2 commits intoOpenFeign:masterfrom Apr 6, 2023
Merged
Conversation
… using package mode
Contributor
Author
|
Class mode (by default) instantiate a JAXBContext using JAXBContext.newInstance(clazz) as it is actually And package mode, if chosen, instantiate using JAXBContext.newInstance(clazz.getPackage().getName(), clazz.getClassLoader()) |
velo
approved these changes
Apr 6, 2023
velo
added a commit
that referenced
this pull request
Oct 7, 2024
… using package mode (#2005) Co-authored-by: jernat <[email protected]> Co-authored-by: Marvin Froeder <[email protected]>
velo
added a commit
that referenced
this pull request
Oct 8, 2024
… using package mode (#2005) Co-authored-by: jernat <[email protected]> Co-authored-by: Marvin Froeder <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I suggest to add a way to choose between class or package instantiation for JaxbContext (class mode is still used by default).
To allow this, the builder of JaxbContextFactory has a new optional method "withJAXBContextInstantiationMode" to provide an enum for the choice between class and package mode. No call to this method = usage of class mode (backward compatible).
Benefits of a package way can be :