Thanks for opening your first OpenLineage pull request! We appreciate your contribution. If you haven't already, please make sure you've reviewed our guide for new contributors (https://github.com/OpenLineage/OpenLineage/blob/main/CONTRIBUTING.md).

@jroachgolf84 some other connectors are using different fields, like BigQuery and Glue, could you make this field depend on adapter type?

https://github.com/dbt-labs/dbt-bigquery/blob/0995665e490cdee9c408d26aac8e1c19fefaebe0/dbt/adapters/bigquery/connections.py#L62C1-L63C1
https://github.com/aws-samples/dbt-glue/blob/main/dbt/adapters/glue/gluedbapi/commons.py#L30

We may need to add some tests to cover this change. We may have to update the documentation - is the facet externalQuery new or did it exist before?

Agreed! There are very few unit-tests to be found for dbt, and not speficially for the DbtArtifactProcessor. Happy to create some! BTW, I should have marked this PR as a draft.

@jroachgolf84 some other connectors are using different fields, like BigQuery and Glue, could you make this field depend on adapter type?

@mobuchowski - for these adapters, is the field name not adapter_response.query_id? Is that only applicable for Snowflake?

@jroachgolf84 I've looked at few, and query_id works for Snowflake and Databricks, but not BigQuery (job_id) or Glue (I think it's statement.id). Some others don't have any query id, like Athena or Redshift.

@mobuchowski, perfect, thanks for the heads up. I'll go ahead and update accordingly.

Do you have any recommendations on the best way to test this? I'd lean towards writing tests only for the get_run() method to start, which would include tests for multiple different connectors. Thoughts? First time contributing to this code-base for me, and I haven't been able to find docs for running unit/integration tests.

@jroachgolf84 we've just added new dbt integration tests: #3872

however they only run duckdb adapter, and it does not include query id in the adapter response.
Maybe you're willing to add Snowflake ones - the relevant connection details should be in the CI test environment.

@mobuchowski, I will most certainly take a look at this. In the meantime, do you have any docs about actually executing unit-tests that have been written already?

@mobuchowski, I've gone ahead and added unit-tests for my changes to the DbtArtifactProcessor.

@kacpermuda, I've implemented each of the changes you outlined. Do you mind taking another look?

Great job! Congrats on your first merged pull request in OpenLineage!

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.11%. Comparing base (6e18732) to head (858833f).
Report is 7 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main    #3890      +/-   ##
==========================================
+ Coverage   85.06%   85.11%   +0.05%     
==========================================
  Files          57       57              
  Lines        3809     3822      +13     
==========================================
+ Hits         3240     3253      +13     
  Misses        569      569              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.