Make visitors stateless - avoid memory leak #3902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddebowczyk92
approved these changes
Jul 15, 2025
f03cb0c to
b4fafed
Compare
Signed-off-by: Pawel Leszczynski <[email protected]>
b4fafed to
658dd65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenLineage 1.27 introduced a change which aimed to optimise flattening RDDs to obtain datasets.
However, the change leaves the reference to the RDD after the chain of:
isDefinedAtandapplymethod is called.This PR merges two existing visitors:
SqlExecutionRDDVisitorandLogicalRDDVisitor. Combining those two classes allows a solution where no reference to RDDs has to be stored as class property.