spark: fix LogicalRelation constructor compatibility for Spark 4 #3930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yunchi Pang <[email protected]>
Member
|
@yunchipang this one also has PMD issues: |
Signed-off-by: Yunchi Pang <[email protected]>
Signed-off-by: Yunchi Pang <[email protected]>
mobuchowski
reviewed
Jul 25, 2025
Comment on lines
+42
to
+53
| try { | ||
| Constructor<?> constructor = getLogicalRelationConstructor(); | ||
| if (constructor.getParameterCount() == SPARK_3_PARAM_COUNT) { | ||
| return Optional.of( | ||
| (LogicalRelation) | ||
| constructor.newInstance(relation, attributes, catalogTable, isStreaming)); | ||
| } else if (constructor.getParameterCount() == SPARK_4_PARAM_COUNT) { | ||
| return Optional.of( | ||
| (LogicalRelation) | ||
| constructor.newInstance( | ||
| relation, attributes, catalogTable, isStreaming, Option.empty())); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
thanks for the review!
mobuchowski
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Spark 4 introduced changes to the
LogicalRelationconstructor signature, causing test failures and requiring version-specific exclusions.Closes: #3885
Solution
Create a
LogicalRelationFactoryutility class that uses reflection to automatically detect and call the appropriate constructor based on the available Spark version.Checklist
SPDX-License-Identifier: Apache-2.0
Copyright 2018-2025 contributors to the OpenLineage project