spec: add ordinal position to SchemaDatasetFacet #4116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
We should probably bump the facet version? |
8ea8d6e to
5dc69a6
Compare
kacpermuda
reviewed
Nov 4, 2025
kacpermuda
approved these changes
Nov 4, 2025
Contributor
kacpermuda
left a comment
There was a problem hiding this comment.
Looks good, apart from the above comment
5dc69a6 to
5df1fa0
Compare
pawel-big-lebowski
approved these changes
Nov 13, 2025
Signed-off-by: Maciej Obuchowski <[email protected]>
5df1fa0 to
be55186
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small addition to spec: ordinal_position that describes the position of the field in schema.
It's 1 indexed, because most of the databases are doing it that way.