fix: PhpUnitAttributesFixer - handle parentheses after data provider method name#8510
Merged
kubawerlos merged 4 commits intoMar 21, 2025
Conversation
Wirone
reviewed
Mar 17, 2025
Comment on lines
+709
to
+710
| #[\PHPUnit\Framework\Attributes\DataProvider('provideFooCases()')] | ||
| #[\PHPUnit\Framework\Attributes\DataProviderExternal(AnotherTest::class, 'provideBarCases()')] |
Member
There was a problem hiding this comment.
Shouldn't it be like this?
Suggested change
| #[\PHPUnit\Framework\Attributes\DataProvider('provideFooCases()')] | |
| #[\PHPUnit\Framework\Attributes\DataProviderExternal(AnotherTest::class, 'provideBarCases()')] | |
| #[\PHPUnit\Framework\Attributes\DataProvider('provideFooCases')] | |
| #[\PHPUnit\Framework\Attributes\DataProviderExternal(AnotherTest::class, 'provideBarCases')] |
(in order to fail pipeline and show that it does not work as expected right now).
Member
Author
There was a problem hiding this comment.
When the bug results in valid syntax I prefer to show the incorrect change rather than the failed pipeline. For 2 reasons:
- Paraunit is not showing diffs (so I have to modify
ci.yamlto run PHPUnit with the single file for such commit) - CI results will expire one day, when the commits in PR will stay with us.
Member
There was a problem hiding this comment.
Then maybe there should be 3 commits:
- test case with existing, invalid behaviour (CI green)
- changes in expectation (CI red)
- actual fix (CI green)
First 2 commits could be pushed together IMHO, as most interesting is to show it does not work as expected (first commit would be mostly for historical reasons). Then the 3rd commit provides a solution. This way it would either show wrong behaviour (1st commit) and correct behaviour (2nd and 3rd commit).
But it's up to you.
keradus
approved these changes
Mar 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8509