Add support for Gradle #3443
Merged
Add support for Gradle #3443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JS File Size Changes (gzipped)A total of 2 files have changed, with a combined diff of +721 B (+29.9%).
|
RunDevelopment
requested changes
Apr 28, 2022
There was a problem hiding this comment.
Thank you for the PR @zeabdelkhalek!
It seems like you based this language of Groovy. That's obviously a good choice, but please adjust the tests. It seems like most of them have just been copied over, so please adjust them. Btw, to update tests quickly, just run npm run test:languages -- --update.
Also, code style. Please copy the code style from languages. npm run lint:fix is probably a good start.
|
@RunDevelopment I have made the necessary changes, could you check again please? |
RunDevelopment
requested changes
Apr 28, 2022
|
@RunDevelopment fixed, can you check again? |
RunDevelopment
requested changes
Apr 29, 2022
|
@RunDevelopment can you check again? |
|
Thank you for contributing @zeabdelkhalek! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #3353