add anyParameterThat and allParameters predicates#1498
Merged
Conversation
Contributor
Author
|
My imagined use-case is checking nullability annotations, for example:
The custom predicates I'm currently using include: private static DescribedPredicate<JavaCodeUnit> usesAnnotation(
Class<? extends Annotation> annotationType) {
return or(be(annotatedWith(annotationType)), have(anyParameter(is(annotatedWith(annotationType)))));
}
private static DescribedPredicate<JavaCodeUnit> anyParameter(
DescribedPredicate<? super JavaParameter> predicate) {
Function<JavaCodeUnit, List<JavaParameter>> getParameters = JavaCodeUnit::getParameters;
return anyElementThat(predicate)
.onResultOf(getParameters)
.as("any parameter that %s", predicate.getDescription());
}and it's particularly annoying that I can't use |
f20202f to
be3457a
Compare
hankem
reviewed
Aug 4, 2025
Member
hankem
left a comment
There was a problem hiding this comment.
Thanks for your contribution! 💚
I've left some comments on HasParameters's JavaDoc. (I think we cannot directly use JavaCodeUnit's.)
390f7c2 to
092f1d9
Compare
Member
|
Could you please rebase the PR onto the |
In another project I'm writing rules about method parameter annotations, and it seems like support for that in the DSL would make sense. This change is the first step towards that, it provides `DescribedPredicate`s for - checking that *any* parameter matches - checking that *all* parameters match Signed-off-by: Martin Kühl <[email protected]>
f668bf8 to
3518bf5
Compare
Contributor
Author
|
done :) |
hankem
approved these changes
Aug 6, 2025
hankem
added a commit
that referenced
this pull request
Aug 6, 2025
In another project I'm writing rules about method parameter annotations, and it seems like support for that in the DSL would make sense. This change is the first step towards that, it extracts a HasParameters interface from JavaCodeUnit and provides DescribedPredicates for - checking that any parameter matches - checking that all parameters match
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In another project I'm writing rules about method parameter annotations,
and it seems like support for that in the DSL would make sense.
This change is the first step towards that,
it extracts a
HasParametersinterface fromJavaCodeUnitand provides
DescribedPredicates for