Make handleLargeSummary also update core.summary #1007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where handleLargeSummary would return a shortened summary but fail to update core.summary, causing the finally block to throw an exception when attempting to write a summary exceeding 1024KB.
Key changes:
- Updates
core.summaryto contain the shortened summary before returning it - Clears the existing buffer and sets it to the shortened summary content to prevent exceeding size limits
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
ljones140
reviewed
Oct 23, 2025
Contributor
ljones140
left a comment
There was a problem hiding this comment.
It looks good.
Thanks for the PR.
Can you generate dist and commit so the CI passes?
ljones140
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this change required?
Although we already have a handleLargeSummary function, prior to this change it would return a shorter summary but it would not update the actual core.summary object.
As core.summary was unaltered by that function the finally block in the
runfunction would throw an exception whenever it called core.summary.write() on a core.summary that exceeded the 1024KB maximum Summary size.Testing