(bug) Fix spamming link test in deprecation warning (again) #1000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'd thought that the syntax in #974 would avoid auto-linking but didn't check closely enough, and now the deprecation issue it links to cannot be loaded due to having too many references. This updates the text to point to a new issue in a way that... I hope... will not be auto-linked.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates a deprecation warning message to avoid auto-linking issues that were causing excessive references to a GitHub issue. The change modifies the text to reference a new issue number in a format that should prevent automatic linking.
- Updated deprecation warning text to reference issue 997 instead of the full GitHub issue path
- Simplified the reference format to avoid auto-linking behavior
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
claire153
approved these changes
Oct 10, 2025
Contributor
claire153
left a comment
There was a problem hiding this comment.
✨ Thank you for doing this!
Also nice that you got PR number 1000
| function addDenyListsDeprecationWarningToSummary(): void { | ||
| core.summary.addRaw( | ||
| `${icons.warning} <strong>Deprecation Warning</strong>: The <em>deny-licenses</em> option is deprecated for possible removal in the next major release. For more information, see actions/dependency-review-action/issues/938.`, | ||
| `${icons.warning} <strong>Deprecation Warning</strong>: The <em>deny-licenses</em> option is deprecated for possible removal in the next major release. For more information, see issue 997.`, |
Contributor
There was a problem hiding this comment.
If you would like to keep the longer version without linking to it, I think we can use back ticks like so:
Suggested change
| `${icons.warning} <strong>Deprecation Warning</strong>: The <em>deny-licenses</em> option is deprecated for possible removal in the next major release. For more information, see issue 997.`, | |
| `${icons.warning} <strong>Deprecation Warning</strong>: The <em>deny-licenses</em> option is deprecated for possible removal in the next major release. For more information, see \`actions/dependency-review-action/issues/997\`.`, |
Contributor
Author
There was a problem hiding this comment.
I tried and this does seem to work, but I'm still a bit scared that they will not be preserved, or the auto linking will happen regardless...
mergify bot
added a commit
to ArcadeData/arcadedb
that referenced
this pull request
Oct 11, 2025
…1 [skip ci] Bumps [actions/dependency-review-action](https://github.com/actions/dependency-review-action) from 4.8.0 to 4.8.1. Release notes *Sourced from [actions/dependency-review-action's releases](https://github.com/actions/dependency-review-action/releases).* > Dependency Review Action v4.8.1 > ------------------------------- > > What's Changed > -------------- > > * (bug) Fix spamming link test in deprecation warning (again) by [`@ahpook`](https://github.com/ahpook) in [actions/dependency-review-action#1000](https://redirect.github.com/actions/dependency-review-action/pull/1000) > * Bump version for 4.8.1 release by [`@ahpook`](https://github.com/ahpook) in [actions/dependency-review-action#1001](https://redirect.github.com/actions/dependency-review-action/pull/1001) > > **Full Changelog**: <actions/dependency-review-action@v4...v4.8.1> Commits * [`40c09b7`](actions/dependency-review-action@40c09b7) Merge pull request [#1001](https://redirect.github.com/actions/dependency-review-action/issues/1001) from actions/ahpook/v4.8.1-release * [`4552948`](actions/dependency-review-action@4552948) Bump version for 4.8.1 release * [`e63da9a`](actions/dependency-review-action@e63da9a) Merge pull request [#1000](https://redirect.github.com/actions/dependency-review-action/issues/1000) from actions/ahpook/deprecation-redux * [`71365c7`](actions/dependency-review-action@71365c7) (bug) Fix spamming link test in deprecation warning (again) * See full diff in [compare view](actions/dependency-review-action@56339e5...40c09b7) [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'd thought that the syntax in #974 would avoid auto-linking
but didn't check closely enough, and now the deprecation issue
it links to cannot be loaded due to having too many references.
This updates the text to point to a new issue in a way that...
I hope... will not be auto-linked.
Related Issues
That's bait