Codestin Search App

chiranjib-swain · 2025-11-24T05:14:18Z

Description:
This pull request updates the labeler function to improve how labels are managed and applied to pull requests, especially when labels may have been added manually or by other bots during the workflow run.

Label management improvements:

The label application logic now fetches the latest labels from the pull request before applying new ones, so it can detect labels that were manually added or added by other bots during the workflow run. It merges these with the labels determined by the config, deduplicates them, and enforces the maximum label limit (GITHUB_MAX_LABELS).
The output for all-labels now reflects the final set of labels actually applied to the pull request, ensuring outputs are accurate and up-to-date..

Related issue:
(#908 , #763).

Check list:

Mark if documentation changes are required.
Mark if tests were added or updated to cover the changes.

…on logic

Copilot

Pull request overview

This PR enhances the labeler action to preserve labels that are manually added or added by other bots during the workflow execution, addressing issue #908. The key improvement is fetching the latest PR labels before applying changes, merging them with config-based labels, and ensuring accurate outputs.

Fetches latest PR labels to detect manual additions during workflow execution
Merges manually added labels with config-based labels while respecting the 100-label limit
Updates the 'all-labels' output to reflect the final applied labels

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 7 comments.

File	Description
src/labeler.ts	Implements label fetching and merging logic to preserve manually added labels, updates output to use final applied labels
dist/index.js	Compiled/bundled version of the TypeScript changes with identical logic updates

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

… labels are prioritized

jnewland

#908 describes a lost update where a user-added label is removed because a setLabels call is made without knowledge of the user-added label. My read of this PR is that it reduces the window of time during which updates can be lost but it does not in any way prevent those lost updates from happening.

I don't believe that ANY approach using setLabels can fix the lost-update problem introduced by #497: setLabels replaces the entire label set in a single write operation, discarding any label changes made since the last read. If concurrent changes are made between the read and write steps - by a user or another workflow - those updates will be overwritten and lost.

I believe the only path towards removing the ability of this action to clobber user writes is to rework it to use addLabels and removeLabels as it did before #497.

chiranjib-swain · 2025-12-16T05:24:43Z

Hi @jnewland ,
Thank you for sharing your thoughts on the label management strategy.

We understand the familiarity with the earlier POST + DELETE approach. After revisiting the long-standing reliability challenges documented in PR #497, we’ve chosen to continue with the setLabels (PUT-based bulk update) method because it offers a more stable and predictable foundation for large or high-activity repositories.

Why we rely on setLabels (PUT)

The previous incremental approach worked for smaller workflows, but at scale it introduced several issues:

High API usage: DELETE removes one label at a time, often triggering rate-limit exhaustion.
Inconsistent retries: The non-atomic POST failed with a 502 error after applying a partial set of over 50 labels. Subsequent retries failed with a 422 error ("more than 100 labels") as the new labels combined with the partially applied ones exceeded the limit.
Unreliable under load: A high volume of PR labels (50+) or concurrent workflow runs increased 5xx errors and incomplete updates due to the nature of POST/DELETE operations.

These problems were significant enough that PR #497 replaced POST/DELETE with a single PUT-based update.

Why PUT is more reliable

Safe to retry (idempotent)
Updates all labels in one atomic call
Enforces GitHub’s 100-label limit before sending the request.
Replaces dozens of DELETE calls with a single operation

This aligns better with the concurrency patterns common in GitHub Actions.

How PR #917 improves this further

PR 917 narrows the read–write race window, preserves manually added labels more consistently, and improves workflow stability when updates happen mid-run.

We truly appreciate your feedback and are open to further discussion on improving label synchronization within the constraints of GitHub’s API.

jnewland · 2025-12-17T20:25:58Z

Thanks for the update. I had forgotten that the label delete API only allows one label to be removed at a time; that's disappointing.

melissawm · 2026-03-06T13:38:09Z

Hi all - it looks like this has been merged but not yet released. Would it be possible to have a new release some time soon for this change to be available? Thank you for your work on this action! ❤️

The previous pin (v6.0.1, 634933e) has a bug where labels added by other workflows during the same run can be removed even with sync-labels: false. This caused Needs-Restricted-Paths-Review to be stripped immediately after being applied (see #1967). Pin to e52e4fb which includes the fix from actions/labeler#917 ("Preserve manually added labels during workflow run and refine label sync logic").

…v6.0.1 → v6.1.0) (#384) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [https://github.com/actions/labeler](https://github.com/actions/labeler) | action | minor | `v6.0.1` → `v6.1.0` | --- ### Release Notes <details> <summary>actions/labeler (https://github.com/actions/labeler)</summary> ### [`v6.1.0`](https://github.com/actions/labeler/releases/tag/v6.1.0) [Compare Source](actions/labeler@v6.0.1...v6.1.0) #### Enhancements - Add changed-files-labels-limit and max-files-changed configuration options to cap the number of labels added by [@bluca](https://github.com/bluca) in [#923](actions/labeler#923) #### Bug Fixes - Improve Labeler Action documentation and permission error handling by [@chiranjib-swain](https://github.com/chiranjib-swain) in [#897](actions/labeler#897) - Preserve manually added labels during workflow runs and refine label synchronization logic by [@chiranjib-swain](https://github.com/chiranjib-swain) in [#917](actions/labeler#917) #### Dependency Updates - Upgrade brace-expansion from 1.1.11 to 1.1.12 and document breaking changes in v6 by [@dependabot](https://github.com/dependabot) in [#877](actions/labeler#877) - Upgrade minimatch from 10.0.1 to 10.2.3 by [@dependabot](https://github.com/dependabot) in [#926](actions/labeler#926) - Upgrade dependencies ([@actions/core](https://github.com/actions/core), [@actions/github](https://github.com/actions/github), js-yaml, minimatch, [@typescript-eslint](https://github.com/typescript-eslint)) by [@Copilot](https://github.com/Copilot) in [#934](actions/labeler#934) #### New Contributors - [@chiranjib-swain](https://github.com/chiranjib-swain) made their first contribution in [#897](actions/labeler#897) - [@bluca](https://github.com/bluca) made their first contribution in [#923](actions/labeler#923) - [@Copilot](https://github.com/Copilot) made their first contribution in [#934](actions/labeler#934) **Full Changelog**: <actions/labeler@v6...v6.1.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.erwanleboucher.dev/eleboucher/homelab/pulls/384

chiranjib-swain · 2026-05-07T03:15:34Z

Hi @melissawm! 👋
Thank you so much for your kind words and your patience!
Great news — we're happy to let you know that v6.1.0 has been released and includes this change.
Please feel free to give it a try and let us know if you run into any issues. We appreciate your support and enthusiasm for this action!

Refactor labeler function to improve label management and deduplicati…

5aa7e7a

…on logic

Copilot AI review requested due to automatic review settings November 24, 2025 05:14

chiranjib-swain requested a review from a team as a code owner November 24, 2025 05:14

Copilot started reviewing on behalf of chiranjib-swain November 24, 2025 05:14 View session

Copilot finished reviewing on behalf of chiranjib-swain November 24, 2025 05:18

Copilot AI reviewed Nov 24, 2025

View reviewed changes

Comment thread src/labeler.ts Outdated

Comment thread src/labeler.ts

Comment thread src/labeler.ts

Comment thread src/labeler.ts Outdated

Comment thread src/labeler.ts Outdated

Comment thread src/labeler.ts Outdated

Comment thread src/labeler.ts

Refactor labeler function to improve label handling and ensure manual…

8f12699

… labels are prioritized

This was referenced Nov 27, 2025

Labeler removed human-applied label with no labeler config #908

Closed

Labeler should never remove labels it has not configured #763

Closed

jnewland suggested changes Dec 2, 2025

View reviewed changes

Comment thread src/labeler.ts

chiranjib-swain mentioned this pull request Dec 12, 2025

Sample PR 9 chiranjib-swain/stale-demo#73

Open

aparnajyothi-y approved these changes Jan 13, 2026

View reviewed changes

gowridurgad approved these changes Jan 13, 2026

View reviewed changes

HarithaVattikuti approved these changes Jan 22, 2026

View reviewed changes

HarithaVattikuti merged commit 77a4082 into actions:main Jan 22, 2026
7 checks passed

krassowski mentioned this pull request Jan 29, 2026

Labeler automation fights with maintainers who add documentation label jupyterlab/jupyterlab#18410

Closed

leofang mentioned this pull request Apr 24, 2026

[BUG]: actions/labeler interference with restricted-paths-guard.yml workflow NVIDIA/cuda-python#1967

Open

leofang mentioned this pull request Apr 24, 2026

[no-ci] Update actions/labeler pin to include #917 fix NVIDIA/cuda-python#1971

Merged

2 tasks

d1rshan mentioned this pull request May 20, 2026

fix(ci): fix local dev label (bump labeler to v6) (@d1rshan) monkeytypegame/monkeytype#7980

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Preserve manually added labels during workflow run and refine label sync logic#917

Fix: Preserve manually added labels during workflow run and refine label sync logic#917
HarithaVattikuti merged 2 commits into
actions:mainfrom
chiranjib-swain:fix/label-preservation-and-sync

chiranjib-swain commented Nov 24, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jnewland left a comment

Uh oh!

Uh oh!

chiranjib-swain commented Dec 16, 2025 •

edited

Loading

Uh oh!

jnewland commented Dec 17, 2025

Uh oh!

Uh oh!

melissawm commented Mar 6, 2026

Uh oh!

chiranjib-swain commented May 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

chiranjib-swain commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jnewland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chiranjib-swain commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why we rely on setLabels (PUT)

Why PUT is more reliable

How PR #917 improves this further

Uh oh!

jnewland commented Dec 17, 2025

Uh oh!

Uh oh!

melissawm commented Mar 6, 2026

Uh oh!

chiranjib-swain commented May 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

chiranjib-swain commented Nov 24, 2025 •

edited

Loading

chiranjib-swain commented Dec 16, 2025 •

edited

Loading