Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

muhserks
Copy link
Contributor

@muhserks muhserks commented Sep 23, 2023

Add request & response headers to newman-allure as attachments (#551)
Changed request body to attachment
Add assertion error message & trace to steps
Add test script syntax error messages

HeadersBodiesAsAttach
stacktrace
syntaxErrorInTestScript

@CLAassistant
Copy link

CLAassistant commented Sep 23, 2023

CLA assistant check
All committers have signed the CLA.

Add assertion error message & trace to steps
Add test script syntax error messages
@muhserks muhserks force-pushed the newman-headers-allure branch from 4a0f896 to ffd180c Compare September 23, 2023 21:46
@muhserks
Copy link
Contributor Author

Shall I break it down into smaller PRs so that it gets reviewed and hopefully approved?
Or did I something wrong so that it is not even worth reviewing?
Please help. Thanks.

@epszaw epszaw self-requested a review November 23, 2023 17:08
@epszaw
Copy link
Member

epszaw commented Nov 23, 2023

@muhserks hey! Sorry for late reply, gonna to review the PR soon

Copy link
Member

@epszaw epszaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job here! Please, pay attention to the comments I've left in the review and also resolve conflicts to continue with the PR

@muhserks muhserks requested a review from epszaw November 28, 2023 14:51
@muhserks
Copy link
Contributor Author

@epszaw Thanks for looking into it.

@epszaw epszaw added the type:new feature New feature or request label Nov 29, 2023
Copy link
Member

@epszaw epszaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job here!

@epszaw
Copy link
Member

epszaw commented Nov 29, 2023

@muhserks run prettier:format and lint:fix scripts before we continue

@muhserks
Copy link
Contributor Author

@epszaw Done.
Thank you very much

@baev baev merged commit 9b32c6c into allure-framework:master Nov 29, 2023
@baev
Copy link
Member

baev commented Nov 29, 2023

@muhserks thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme:newman type:new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants